Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-337] upgrade R, R studio to latest version on hubs #5945

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented Aug 12, 2024

https://jira-secure.berkeley.edu/browse/DH-337

fwiw, biology is gonna be a chore... that image basically needs to be completely redone from scratch.

bio was actually much easier than anticipated, but boy-howdy that Dockerfile is a mess.

Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks thorough. We won't be able to anticipate libraries that are incompatible with this change. We should test various R graphics outputs in staging.

Could you please also bump shiny-server from 1.5.21 to 1.5.22 in the shiny Dockerfile? Mostly this is to avoid another CI run, but ideally would should bump shiny-server at the same time as RStudio and R.

@ryanlovett
Copy link
Collaborator

Actually, since the shiny test already passed, we should delay shiny-server bump to a different PR to prevent another CI run for all affected images.

Copy link
Contributor

@balajialg balajialg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, wish I had communicated the R upgrade as part of the onboarding email. We should probably test multiple course notebooks to verify whether RStudio/Shiny works fine in Datahub, R, Public Health and ISchool Hubs. Sharing some course repos for testing,

Datahub/R hub:
https://github.com/ds-modules/PS3-SU23/tree/main
https://github.com/ds-modules/ECON-140-FA22-RDE/tree/main

Ischool Hub:
https://github.com/UCB-MIDS/w241

PH Hub:
https://github.com/ph142-ucb/ph142-su24

Shiny Hub:
https://github.com/ds-modules/polisci-3

@shaneknapp
Copy link
Contributor Author

Actually, since the shiny test already passed, we should delay shiny-server bump to a different PR to prevent another CI run for all affected images.

tbf, it's not a big deal and i'll cancel the current build(s) and make the change(s).

@shaneknapp shaneknapp changed the title [DH-337] upgrade R to latest version on hubs [DH-337] upgrade R, R studio to latest version on hubs Aug 12, 2024
@shaneknapp shaneknapp merged commit 7337e4a into berkeley-dsep-infra:staging Aug 12, 2024
21 checks passed
@shaneknapp shaneknapp deleted the upgrade-r branch August 12, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants